1. 09 Dec, 2016 11 commits
  2. 08 Dec, 2016 3 commits
  3. 07 Dec, 2016 8 commits
  4. 06 Dec, 2016 4 commits
    • Torsten Grote's avatar
      7f5a5d40
    • Torsten Grote's avatar
      Fix Sharing Status screens · 98dd8ec7
      Torsten Grote authored
      * Remove distinction between "shared with" and "shared by"
      * Show all contacts a blog is shared with
      * Show online status of contacts in sharing screen
      98dd8ec7
    • akwizgran's avatar
      Merge branch '548-require-a-label-for-hashing' into 'master' · 27c2ee8d
      akwizgran authored
      Require a label for hashing
      
      * Add a string label argument to `CryptoComponent#hash()`
      * Convert `DoubleDigest` from implementing `MessageDigest`
        to implementing `org.spongycastle.crypto.Digest`
        (we need to keep `DoubleDigest` for `FortunaGenerator`)
      * Convert all other uses of `MessageDigest` to `CryptoComponent#hash()`
      * Remove `CryptoComponent#getMessageDigest()`, `MessageDigest` and `DigestWrapper`
      
      Closes #548
      
      See merge request !442
      27c2ee8d
    • Torsten Grote's avatar
      Merge branch '283-die-bluetooth-die' into 'master' · b98ab93e
      Torsten Grote authored
      Ensure key agreement tasks finish if they ignore interrupts
      
      The problem here was that `BluetoothSocket#connect()` was throwing an IOException when the task was interrupted - the task treated this like any other connection failure and retried, so the task never finished.
      
      The fix is to check whether the timeout has expired before retrying, so the task eventually finishes even if it ignores the original interrupt.
      
      Closes #283
      
      See merge request !443
      b98ab93e
  5. 05 Dec, 2016 4 commits
  6. 02 Dec, 2016 2 commits
  7. 01 Dec, 2016 5 commits
  8. 30 Nov, 2016 3 commits
    • akwizgran's avatar
      Updated java.library.path. · ad6016d4
      akwizgran authored
      ad6016d4
    • akwizgran's avatar
      Merge branch '705-blog-pager-race-conditions' into 'master' · f6d23b4d
      akwizgran authored
      Remove blog pagers
      
      I set out to fix potential race conditions in the blog pagers (the screens you reach by tapping the body of a blog post, that allow you to swipe left and right through the posts in the combined feed or a single blog). The race conditions here are similar to those addressed by !356, but the adapters don't inherit from BriarAdapter so they need to be fixed separately.
      
      While I was looking into this I found a few minor problems with the pagers:
      * The feed pager wasn't responding to events - this was fixed in !398
      * The feed pager finishes NavDrawerActivity when any blog is removed
      * The feed isn't updated when a blog is added (this applies to the list view as well as the pager)
      * Posts aren't removed from the feed pager when a blog is removed
      
      The last problem is quite serious - the feed pager's adapter contains posts that are no longer in the DB, so they'll fail to load. To fix that problem, the adapter needs to be cleared in onStop() and repopulated in onStart(). This is the same approach we use for other adapters where items can be removed from the underlying dataset. Unfortunately, FragmentStatePagerAdapter has some odd behaviour when you clear and repopulate it:
      
      1. When reselecting the previously selected item after clearing and repopulating the adapter, the item slides into view instead of just appearing, which makes it look like you've accidentally swiped.
      2. Items are sometimes duplicated when clearing and repopulating the adapter, so swiping left or right shows another copy of the same post.
      
      These problems only seem to happen if the adapter is cleared - adding new posts works fine on master, although I think there might be some luck involved - FragmentStatePagerAdapter doesn't seem to be designed to support items changing positions.
      
      I spent a lot of time trying to resolve these problems before concluding that maybe it wasn't worth it, and we should just remove the pagers. That's what's currently implemented in this branch. Tapping the body of a post will show the full-length post, but you won't be able to swipe left or right.
      
      The swiping functionality was nice to have, so if you have ideas for fixing the bugs I'd love to hear them. But I'd rather remove this functionality than keep it in a buggy state with no plan for how to fix it.
      
      Closes #705
      
      See merge request !400
      f6d23b4d
    • akwizgran's avatar
      Merge branch '760-integration-tests-for-private-group-invitation-protocol' into 'master' · aa064e85
      akwizgran authored
      Add integration tests for GroupInvitationManager
      
      This MR is based on !433. It adds some integration tests for the private group invitation protocol. One of those tests fails at the moment.
      
      It does not yet cover all corner cases, so it does not fully address #760, but addresses a part of it. Suggestions for more scenarios to test are welcome.
      
      [Wording changed to prevent #760 from being closed automatically based on the description.]
      
      See merge request !434
      aa064e85