Skip to content
Snippets Groups Projects
  1. Oct 05, 2016
    • akwizgran's avatar
      Remove unused UI code and layouts. · 604542c1
      akwizgran authored
      604542c1
    • Torsten Grote's avatar
      Merge branch '680-release-camera-surface' into 'master' · 3fa84ec7
      Torsten Grote authored
      Release camera surface to work around Android bug #54285
      
      Closes #680
      
      See merge request !340
      3fa84ec7
    • Torsten Grote's avatar
      Merge branch 'identicon-cleanup' into 'master' · e5f55111
      Torsten Grote authored
      Clean up identicon code, remove unused classes
      
      I noticed some debug-level logging coming from the identicon code, went in there to remove it, and realised half the code was unused, so I removed that too.
      
      No functional changes except that the logging is gone and the opacity is now OPAQUE rather than UNKNOWN, which wasn't valid in this context.
      
      See merge request !339
      e5f55111
    • akwizgran's avatar
      16ecb2ce
    • akwizgran's avatar
      Merge branch '644-missing-header' into 'master' · c49c888f
      akwizgran authored
      Remove loading callbacks from fragment listener
      
      Now fragments are responsible for their own Progress bars.
      
      Closes #642
      
      See merge request !316
      c49c888f
    • Ernir Erlingsson's avatar
    • akwizgran's avatar
      Merge branch '92-emoticons' into 'master' · 293c06fd
      akwizgran authored
      Emoji Support for all user input
      
      All text that can be generated by users will show emoji from the shipped sprites by using the `EmojiTextView` instead of the normal `TextView`.
      
      For all messages and posts, the custom emoji keyboard is now available as well. For this, a new `LargeTextInputView` has been introduced that is a sub-class of `TextInputView`. In order for the emoticon keyboard to work properly the existing views had to be modified heavily, sometimes resulting in new behavior such as scroll views now being above the fixed input field. Actual testing on a device (preferably with a tiny screen) is recommended to make sure this still works as expected. Screenshots will be included at the end of this post.
      
      This MR also disables menu actions rather than hiding them and it includes a fix for a regression that was not showing the keyboard automatically in forums.
      
      ![device-2016-09-28-104914](/uploads/8ce9c8f61b32dc5a46b89a3a2cf1e6a4/device-2016-09-28-104914.png)
      ![device-2016-09-28-105026](/uploads/96ef9c40547c7a44fbc4517c87637a7e/device-2016-09-28-105026.png)
      ![device-2016-09-28-105041](/uploads/a0d1ed23ccb66e8bf9541737407142e3/device-2016-09-28-105041.png)
      ![device-2016-09-28-105440](/uploads/fb76ed2adc87600cfb0fc33c3962d4a6/device-2016-09-28-105440.png)
      ![device-2016-09-28-105515](/uploads/51f845d697cee3df38d1b9eef3c0ddfc/device-2016-09-28-105515.png)
      
      Closes #92
      
      See merge request !329
      293c06fd
  2. Oct 04, 2016
    • akwizgran's avatar
      Merge branch '695-introduction-failure' into 'master' · 1c55fae7
      akwizgran authored
      Fix regression in IntroduceeManager
      
      This was happening when the remote response arrives before the local
      response is made and thus the local response needs to be send with the
      ACK following. The problem was that we ACK was sent before the response
      which is not allowed and resulted in the session being aborted by the
      introducee. This was happening, because recursion is hard ;)
      
      The fix is only restarting another protocol engine to send the ACK
      after the first run has been completed.
      
      An integration test was added to prevent such regression in the future
      and to test this code path.
      
      Closes #695
      
      See merge request !338
      1c55fae7
    • Torsten Grote's avatar
      Fix regression in IntroduceeManager · 95670937
      Torsten Grote authored
      This was happening when the remote response arrives before the local
      response is made and thus the local response needs to be send with the
      ACK following. The problem was that we ACK was sent before the response
      which is not allowed and resulted in the session being aborted by the
      introducee. This was happening, because recursion is hard ;)
      
      The fix is only restarting another protocol engine to send the ACK
      after the first run has been completed.
      
      An integration test was added to prevent such regression in the future
      and to test this code path.
      95670937
    • Ernir Erlingsson's avatar
      Merge branch '690-introduction-onboarding-is-shown-again-if-it-s-dismissed' into 'master' · 165deebb
      Ernir Erlingsson authored
      Don't show introduction onboarding again no matter how dismissed
      
      Closes #690
      
      See merge request !337
      165deebb
    • Torsten Grote's avatar
    • Torsten Grote's avatar
      Emoji Support for all user input · f8e0441d
      Torsten Grote authored
      All text that can be generated by users will show emoji from the
      shipped sprites.
      
      For all messages and posts, the custom emoji keyboard is now available.
      
      This also disables menu actions rather than hiding them and thus
      closes #677
      
      Included is a fix for a regression that was not showing the keyboard
      automatically in forums and thus
      closes #676
      f8e0441d
  3. Oct 03, 2016
    • akwizgran's avatar
      Merge branch '673-privategroupmanager-facade' into 'master' · a422c626
      akwizgran authored
      Create PrivateGroupManager Facade and stub implementation
      
      Some classes were renamed and new base classes introduced in the process. I suggest to expand the "Changed files" before reviewing to get an overview over the changes.
      
      Closes #673
      
      See merge request !332
      a422c626
  4. Sep 30, 2016
  5. Sep 29, 2016
  6. Sep 28, 2016
    • Ernir Erlingsson's avatar
      92f2e7b0
    • akwizgran's avatar
      Merge branch '644-missing-header-only' into 'master' · ee989006
      akwizgran authored
      Remove toolbar animation to fix the missing toolbar on first start
      
      Closes #644
      
      See merge request !331
      ee989006
    • akwizgran's avatar
      747553f5
    • Torsten Grote's avatar
    • akwizgran's avatar
      Merge branch '679-own-personal-blogs-can-be-removed' into 'master' · 7e806c8c
      akwizgran authored
      Prevent personal blogs from being removed
      
      This also adds unit tests to prevent regressions like this in the future.
      
      Closes #679
      
      See merge request !330
      7e806c8c
    • akwizgran's avatar
      Merge branch '589-when-a-message-is-shared-share-its-transitive-dependencies' into 'master' · e466ed58
      akwizgran authored
      When a message is shared, share its transitive dependencies
      
      Like other recursive operations on the dependency graph, this is
      not done in a single transaction to prevent an attacker from creating
      arbitrary large transactions.
      
      So at startup, the `ValidationManager` finds and resumes any
      unfinished operations, by looking for unshared messages with shared
      dependents.
      
      Closes #589
      
      See merge request !325
      e466ed58
    • Torsten Grote's avatar
      When a message is shared, share its transitive dependencies · d0581724
      Torsten Grote authored
      Like other recursive operations on the dependency graph, this is
      not done in a single transaction to prevent an attacker from creating
      arbitrary large transactions.
      
      So at startup, the `ValidationManager` finds and resumes any
      unfinished operations, by looking for shared messages with unshared
      dependencies.
      d0581724
    • Torsten Grote's avatar
      Prevent personal blogs from being removed · 1f0b3051
      Torsten Grote authored
      This also adds unit tests to prevent regressions like this in the
      future.
      1f0b3051
    • Torsten Grote's avatar
      bump expiry date and update translations · 7a0db798
      Torsten Grote authored
      7a0db798
    • Torsten Grote's avatar
      Merge branch '346-camera-parameters' into 'master' · 7e6a522e
      Torsten Grote authored
      Try harder to find suitable camera parameters
      
      This branch fixes QR code scanning on the Galaxy Nexus running Cyanogen Mod 12.1 (Android 5.1.1), without breaking QR code scanning on any of the other test devices.
      
      The problem on the Galaxy Nexus was that the selected scene mode was overriding the selected focus mode, so we asked for continuous picture mode but got macro mode. Macro mode requires startAutoFocus() to be called, but we weren't calling it because we'd asked for continuous picture mode.
      
      The fix for that problem is to query the focus mode after applying the parameters and call startAutoFocus() based on the actual mode rather than the requested mode.
      
      But then I discovered another problem: barcode scene mode was setting the flash to auto, so in low light the flash was turning on and off while trying to scan QR codes. That might work well for printed QR codes, but it's terrible when scanning from a screen.
      
      The fix for the new problem is to select barcode scene mode, then try to disable the flash, and if that fails, reset the scene mode. Then we pick the best available video stabilisation, focus mode and preview size.
      
      On the Galaxy Nexus with CM 12.1, that means we use continuous picture mode instead of barcode scene mode, which works fine. All the other test devices pick the same settings as before.
      
      See merge request !321
      7e6a522e
  7. Sep 27, 2016
Loading